Allow to monitor Windows hosts#6803
Merged
Merged
Conversation
pvizeli
reviewed
Mar 27, 2017
Member
pvizeli
left a comment
pvizeli
left a comment
There was a problem hiding this comment.
Is it not faster if we check the os instead trow a exeption ever x seconds for out stack?
emlove
approved these changes
Mar 27, 2017
Contributor
There was a problem hiding this comment.
I think this implementation is preferable to checking the OS. Windows is one example but other OSes might behave the same, and other Windows versions could change behavior.
I think catching key errors is a pretty standard python practice. You could also branch with if 'load' in value:, but I'm not sure if there's a substantial difference.
Member
Author
|
As soon as I can get my hands on a Windows hosts I can probably provide a more robust solution. |
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Catch the exception of Windows hosts as they don't provide
loaddetails.Related issue (if applicable): fixes #6482
Example entry for
configuration.yaml(if applicable):Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass